Support Exposing new Metric properties using EventSource #90417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp list |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
noahfalk
reviewed
Aug 11, 2023
| @@ -34,7 +34,7 @@ namespace System.Diagnostics.Metrics | |||
| // it may also not be a win to further pessimize the slow-path (JIT compilation is expensive) to squeeze yet more cycles out of | |||
| // the fast path. | |||
| // - Allocations per lookup: Any lookup of 3 or fewer labels on the above fast path is allocation free. We have separate | |||
| // dictionaries dependending on the number of labels in the list and the dictionary keys are structures representing fixed size | |||
| // dictionaries depending on the number of labels in the list and the dictionary keys are structures representing fixed size | |||
There was a problem hiding this comment.
Haha, that was some interesting spelling I came up with ;p
|
Opened #90439 for the unrelated failure. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87150