Apply objc_msgsend fix to src/mono too and fix build on earlier Xcode #90217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing the objc_msgsend fix from dotnet#89932 in the mono build. Also fix an issue where CMake would complain about wrong number of arguments when CLR_CMAKE_COMMON_OBJC_FLAGS is empty, we need put the variable in quotes.
akoeplinger
requested review from
SamMonoRT,
lambdageek,
marek-safar and
vargaz
as code owners
jakobbotsch
approved these changes
Aug 9, 2023
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 25, 2023
…ith Xcode 13 Backport of dotnet#89932 and dotnet#90217 to release/7.0
This was referenced Aug 25, 2023
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 25, 2023
…ith Xcode 13 Backport of dotnet#89932 and dotnet#90217 to release/6.0
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the objc_msgsend fix from #89932 in the mono build.
Also fix an issue where CMake would complain about wrong number of arguments when CLR_CMAKE_COMMON_OBJC_FLAGS is empty, we need put the variable in quotes.