Skip to content

Fix analyzer warning that is breaking the build #90136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix analyzer warning that is breaking the build #90136

merged 1 commit into from
Aug 8, 2023

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Aug 8, 2023

Currently failing with error:

error CA1868: Do not guard 'HashSet.Add(string)' with 'HashSet.Contains(string)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1868)

@ghost ghost assigned eiriktsarpalis Aug 8, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 8, 2023
adamsitnik
adamsitnik approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing the build @eiriktsarpalis

BTW it would be great to understand why the build got broken (I imagine that enabling new analyzers should require a new PR that should simply fail and require a fix before being merged)

Edit: #89869 most likely run the CI checks before the new analyzer got enabled

@ghost
Copy link

ghost commented Aug 8, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently failing with error:

error CA1868: Do not guard 'HashSet.Add(string)' with 'HashSet.Contains(string)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1868)
Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-Infrastructure-mono, needs-area-label
Milestone: -

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 8, 2023

Fast merge to unblock CI.

@ViktorHofer ViktorHofer merged commit a409892 into dotnet:main Aug 8, 2023
@adamsitnik
Copy link
Member

adamsitnik commented Aug 8, 2023

Fast merge to unblock CI.

image

Jokes aside I am very supportive of that!

@eiriktsarpalis
Copy link
Member Author

eiriktsarpalis commented Aug 8, 2023

I also want that badge now 🤣

@eiriktsarpalis eiriktsarpalis mentioned this pull request Aug 8, 2023
Merged
@anatawa12 anatawa12 mentioned this pull request Aug 8, 2023
Merged
@eiriktsarpalis eiriktsarpalis deleted the fix-analyzer-warning branch August 8, 2023 12:47
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-Infrastructure-mono needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eiriktsarpalis @ViktorHofer @adamsitnik