[browser] fix loading assets #89687
Merged
[browser] fix loading assets #89687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
This was referenced Jul 30, 2023
…L with document.baseURI, added makeURLAbsoluteWithApplicationBase - add new last parameter to loadBootResource call with runime behavior type, remove double call to loadBootResource - add manifest, js-module-loader to AssetBehaviors - add WebAssemblyBootResourceType back - rename jsSymbols to wasmSymbols, this was a mistake
kg
reviewed
Aug 1, 2023
kg
reviewed
Aug 1, 2023
kg
reviewed
Aug 1, 2023
kg
reviewed
Aug 1, 2023
kg
reviewed
Aug 1, 2023
kg
reviewed
Aug 1, 2023
kg
approved these changes
Aug 1, 2023
|
Is the sample testing the issue being fixed here? Can we please move to a WBT test? Having it in a sample makes it breakable in future, because we won't really know what it was testing necessarily. And somebody trying to clean up, or improve the code might break remove the things that we wanted to test. |
About The |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadBootResourceto absolute URL withdocument.baseURImakeURLAbsoluteWithApplicationBaseloadBootResourcecall with runime behavior type,loadBootResourcemanifest,js-module-dotnettoAssetBehaviorsWebAssemblyBootResourceTypeback todotnet.d.tsjsSymbolstowasmSymbols, this was a mistakebrowser-minimal-configsampleconfig.assetsFixes #89510
Fixes #89570
Fixes #89766