Skip to content

Respect CopyOutputSymbolsToPublishDirectory in PublishAot #88815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

MichalStrehovsky
Copy link
Member

Fixes dotnet/sdk#33476.

Cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Jul 13, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes dotnet/sdk#33476.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@am11
Copy link
Member

am11 commented Jul 13, 2023

Should we set CopyOutputSymbolsToPublishDirectory=false for Configuration=Release? (assuming its default value is true)

@MichalStrehovsky
Copy link
Member Author

Should we set CopyOutputSymbolsToPublishDirectory=false for Configuration=Release?

The .NET convention is to copy them to publish output, with a possibility to opt out. (This property is not new - it already works for non-AOT publish and this is the default, irrespective of configuration.)

@MichalStrehovsky MichalStrehovsky merged commit 5d6587a into dotnet:main Jul 13, 2023
@MichalStrehovsky MichalStrehovsky deleted the fixsdk33476 branch July 13, 2023 23:58
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAOT StripSymbols should allow options for what to do with the symbol file
4 participants