Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move startup validation to the options assembly #88546

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

steveharter
Copy link
Member

Fixes #84347

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 8, 2023

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #84347

Author: steveharter
Assignees: steveharter
Labels:

area-Extensions-Options

Milestone: 8.0.0

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few NIT, overall LGTM

@steveharter steveharter merged commit 693eef6 into dotnet:main Jul 12, 2023
101 of 103 checks passed
@steveharter steveharter deleted the ValidationToOptions branch July 12, 2023 13:48
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Decouple ValidateOnStart from Hosting
2 participants