Skip to content

[nativeaot][perf] Simplify the build process for the perf measurements #88201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kotlarmilos
Copy link
Member

This PR aims to simplify the build process by first building the native and host components before building the application.

Fixes the issue of a failing Native AOT perf build.

[ 13%] Building CXX object vm/CMakeFiles/cee_dac.dir/cmake_pch_x86_64.hxx.pch
  In file included from <built-in>:1:
  In file included from /Users/runner/work/1/s/artifacts/obj/coreclr/osx.x64.Release/vm/CMakeFiles/cee_dac.dir/cmake_pch_x86_64.hxx:5:
  In file included from /Users/runner/work/1/s/src/coreclr/vm/common.h:83:
  /Users/runner/work/1/s/src/coreclr/pal/inc/../../debug/inc/dbgtargetcontext.h:296:1: error: static_assert failed due to requirement 'sizeof(DT_CONTEXT) == sizeof(_CONTEXT)' "DT_CONTEXT size must equal the T_CONTEXT size on AMD64"
  static_assert(sizeof(DT_CONTEXT) == sizeof(T_CONTEXT), "DT_CONTEXT size must equal the T_CONTEXT size on AMD64");
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@kotlarmilos kotlarmilos requested a review from LoopedBard3 June 29, 2023 16:20
@kotlarmilos kotlarmilos requested a review from radical as a code owner June 29, 2023 16:20
@kotlarmilos kotlarmilos self-assigned this Jun 29, 2023
@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR aims to simplify the build process by first building the native and host components before building the application.

Fixes the issue of a failing Native AOT perf build.

[ 13%] Building CXX object vm/CMakeFiles/cee_dac.dir/cmake_pch_x86_64.hxx.pch
  In file included from <built-in>:1:
  In file included from /Users/runner/work/1/s/artifacts/obj/coreclr/osx.x64.Release/vm/CMakeFiles/cee_dac.dir/cmake_pch_x86_64.hxx:5:
  In file included from /Users/runner/work/1/s/src/coreclr/vm/common.h:83:
  /Users/runner/work/1/s/src/coreclr/pal/inc/../../debug/inc/dbgtargetcontext.h:296:1: error: static_assert failed due to requirement 'sizeof(DT_CONTEXT) == sizeof(_CONTEXT)' "DT_CONTEXT size must equal the T_CONTEXT size on AMD64"
  static_assert(sizeof(DT_CONTEXT) == sizeof(T_CONTEXT), "DT_CONTEXT size must equal the T_CONTEXT size on AMD64");
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure, os-ios

Milestone: -

@kotlarmilos
Copy link
Member Author

https://dev.azure.com/dnceng/internal/_build/results?buildId=2211992&view=results

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@kotlarmilos kotlarmilos merged commit 3296baa into dotnet:main Jun 30, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants