Clean up JIT flags #87588
Merged
Clean up JIT flags #87588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
1. Remove never set CORJIT_MCJIT_BACKGROUND. 2. Remove never checked CORJIT_PINVOKE_RESTORE_ESP (x86 only). Remove related `COMPUTED_IS_PRE_V4_ASSEMBLY`, `IS_PRE_V4_ASSEMBLY`, `IsPreV4Assembly()`. 3. Remove unused CORJIT_FEATURE_SIMD. 4. Remove all the "UNUSED" flags, which only cause clutter. 5. Renumber/pack all the remaining flags. Ensure that all flags have unique numbers, even for different platforms. 6. Add missing flags in a few cases: the JIT/CORJIT equality asserts, mcs "-jitflags" dumpers, `CorJitFlagToString()`, `CorJitFlag` type.
BruceForstall
force-pushed
the
CleanUpJitFlags
branch
from
391c36a to
47bf469
Compare
BruceForstall
commented
Jun 15, 2023
|
@AndyAyersMS PTAL @AaronRobinsonMSFT PTAL at the CORJIT_PINVOKE_RESTORE_ESP related change |
jkotas
reviewed
Jun 15, 2023
jkotas
reviewed
Jun 15, 2023
AaronRobinsonMSFT
approved these changes
Jun 15, 2023
AndyAyersMS
approved these changes
Jun 15, 2023
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I updated this to remove all the unused JIT-EE interface methods/types listed in #86672. There is one commit for each item removed. (Maybe this change should be merged without squashing, to preserve that?) |
|
Test failures all look known or infra. |
Sounds good to me. I am going to merge as rebase. |
13 tasks
❤️ |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPUTED_IS_PRE_V4_ASSEMBLY,IS_PRE_V4_ASSEMBLY,IsPreV4Assembly().numbers, even for different platforms.
dumpers,
CorJitFlagToString(),CorJitFlagtype.