Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Jun 8, 2023

No description provided.

@Thefrank
Copy link
Contributor

It took until this patch for me to check the runtime.freebsd-x64.Microsoft.DotNet.ILCompiler* nugets generated from crossbuilds.

It turns out they were all linux ELFs. Nothing appears to have consumed it so when building natively so it was uncaught. shrug

@MichalStrehovsky
Copy link
Member

It took until this patch for me to check the runtime.freebsd-x64.Microsoft.DotNet.ILCompiler* nugets generated from crossbuilds.

It turns out they were all linux ELFs. Nothing appears to have consumed it so when building natively so it was uncaught. shrug

We don't use the contents of the package as part of the repo build. The packages are smoke tested in the dotnet/sdk repo unit tests. If you wanted to test the built packages locally, you'd need to use https://github.com/dotnet/runtime/blob/main/docs/workflow/building/coreclr/nativeaot.md#building-packages this workflow ("Building packages").

@am11
Copy link
Member

am11 commented Jun 13, 2023

It took until this patch for me to check the runtime.freebsd-x64.Microsoft.DotNet.ILCompiler* nugets generated from crossbuilds.

It was fine before b8e0ce0 right? FreeBSD and other OS were disabled before last week, now we are only disabling FreeBSD and it is still breaking the others. We should bring back the original condition or use this one:

<!-- Publish crossgen2 as a single-file app on native-OS builds. Cross-OS NativeAOT compilation is not supported yet -->
<NativeAotSupported Condition="'$(CrossBuild)' == 'true' and '$(TargetOS)' != '$(HostOS)'">false</NativeAotSupported>

@Thefrank
Copy link
Contributor

It was fine before b8e0ce0 right?

Just checked:
runtime.freebsd-x64.Microsoft.DotNet.ILCompiler.8.0.0-preview.3.23174.8 and runtime.freebsd-x64.Microsoft.DotNet.ILCompiler.8.0.0-preview.4.23259.5 both contain Linux ELFs. They were crossbuild from tags/PREVIEWNUM from dotnet/runtime.
It was building before b8e0ce0 but it appears it was always generating the wrong package for ILCompiler. Other packages like Crossgen2 and ILAsm have FreeBSD ELFs in them.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants