-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update APICompat.Task to latest version #87046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5291075
Update APICompat.Task to latest version
ViktorHofer 30bebbe
Suppress new errors that were intentionally made
ViktorHofer a1c56d6
Update Version.Details.xml
ViktorHofer c6ffbd4
Update CompatibilitySuppressions.xml
ViktorHofer 3c5be87
Update CompatibilitySuppressions.xml
ViktorHofer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/libraries/Microsoft.Extensions.DependencyInjection/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <!-- RequiresDynamicCodeAttribute was removed during .NET 8 with https://github.com/dotnet/runtime/commit/f424c0f7ce8b1453d7124a3def8cf44a4ff42ead. --> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection,Microsoft.Extensions.DependencyInjection.ServiceProviderOptions):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Boolean):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>T:Microsoft.Extensions.DependencyInjection.DefaultServiceProviderFactory:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
82 changes: 82 additions & 0 deletions
82
src/libraries/Microsoft.Extensions.Hosting/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <!-- RequiresDynamicCode attributes removed during .NET 8: https://github.com/dotnet/runtime/commit/f424c0f7ce8b1453d7124a3def8cf44a4ff42ead. --> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.Host.CreateApplicationBuilder:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.Host.CreateApplicationBuilder(System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.Host.CreateDefaultBuilder:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.Host.CreateDefaultBuilder(System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostApplicationBuilder.#ctor:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostApplicationBuilder.#ctor(Microsoft.Extensions.Hosting.HostApplicationBuilderSettings):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostApplicationBuilder.#ctor(System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostBuilder.#ctor:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.ConfigureDefaults(Microsoft.Extensions.Hosting.IHostBuilder,System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.UseDefaultServiceProvider(Microsoft.Extensions.Hosting.IHostBuilder,System.Action{Microsoft.Extensions.DependencyInjection.ServiceProviderOptions}):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.UseDefaultServiceProvider(Microsoft.Extensions.Hosting.IHostBuilder,System.Action{Microsoft.Extensions.Hosting.HostBuilderContext,Microsoft.Extensions.DependencyInjection.ServiceProviderOptions}):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
12 changes: 12 additions & 0 deletions
12
src/libraries/Microsoft.Extensions.Logging/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <!-- RequiresDynamicCodeAttribute was removed during .NET 8 with https://github.com/dotnet/runtime/commit/f424c0f7ce8b1453d7124a3def8cf44a4ff42ead. --> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:Microsoft.Extensions.Logging.LoggerFactory.Create(System.Action{Microsoft.Extensions.Logging.ILoggingBuilder}):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/Microsoft.Extensions.Logging.dll</Left> | ||
| <Right>lib/net7.0/Microsoft.Extensions.Logging.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/libraries/System.Diagnostics.DiagnosticSource/src/CompatibilitySuppressions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <!-- DiagnosticSource made NativeAOT compatible during .NET 8: https://github.com/dotnet/runtime/commit/70b33f8f69128eeb1463691e24646987b54a0e3d. --> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:System.Diagnostics.DiagnosticListener.Write(System.String,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left> | ||
| <Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:System.Diagnostics.DiagnosticSource.StartActivity(System.Diagnostics.Activity,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left> | ||
| <Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:System.Diagnostics.DiagnosticSource.StopActivity(System.Diagnostics.Activity,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left> | ||
| <Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0014</DiagnosticId> | ||
| <Target>M:System.Diagnostics.DiagnosticSource.Write(System.String,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target> | ||
| <Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left> | ||
| <Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we use the version that comes with the SDK? So then we don't have to manually update it. I see it is 4 previews old right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to have a subscription that apparently got stale. We want to consume the very latest features from APICompat. dotnet/runtime is our dogfood repository for APICompat. For this specific case, I just yesterday merged dotnet/sdk#32930 and would need to wait 1-2 months until I could consume the change in dotnet/runtime.
The second reason for using the NuGet package over what's inside the SDK is that the nuget package includes msbuild target files for 1:1 assembly comparison (ref <--> src) which isn't yet available in the SDK.