Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use the cbl-mariner webassembly images. #86806

Merged
merged 8 commits into from
Jun 9, 2023

Conversation

jkoritzinsky
Copy link
Member

This is one of the last official build targets that we weren't already using CBL-Mariner to build with.

@ghost
Copy link

ghost commented May 26, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This is one of the last official build targets that we weren't already using CBL-Mariner to build with.

Author: jkoritzinsky
Assignees: jkoritzinsky
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented May 26, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This is one of the last official build targets that we weren't already using CBL-Mariner to build with.

Author: jkoritzinsky
Assignees: jkoritzinsky
Labels:

arch-wasm, area-Infrastructure

Milestone: -

@directhex
Copy link
Contributor

These images are 100% borked right now, yes? I just tried to use them for ICU, and am getting Docker errors

@jkoritzinsky
Copy link
Member Author

Guess I missed some of the AzDO requirements for the containers...

@jkoritzinsky
Copy link
Member Author

/azp run runtime, dotnet-linker-tests, runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jkoritzinsky
Copy link
Member Author

The WASM legs build the apps on the build system, so the mono-aot-cross executable needs to be able to run on the Helix machines. Need to figure out the best way to handle this.

@radical radical self-requested a review May 30, 2023 18:48
@radical
Copy link
Member

radical commented May 30, 2023

mono-aot-cross: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm/8.0.0-ci/Sdk/../tools/mono-aot-cross)
mono-aot-cross: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm/8.0.0-ci/Sdk/../tools/mono-aot-cross)
mono-aot-cross: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm/8.0.0-ci/Sdk/../tools/mono-aot-cross)
mono-aot-cross: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm/8.0.0-ci/Sdk/../tools/mono-aot-cross)

mono-aot-cross is being built on the build machines with mariner, but then used on helix which is still running ubuntu 18.04 .

@directhex
Copy link
Contributor

Those numbers don't line up, glibc 2.34 is not what Mariner-built stuff should be offering. Our Mariner build images have the Mariner base OS, and are SUPPOSED TO cross-compile against a target OS (Ubuntu 16.04 in most cases) in /crossrootfs. 2.34 is WAY newer than that, it's like Ubuntu 21.10 or something (or maybe even the Mariner base itself? As opposed to the crossroot?)

@jkoritzinsky
Copy link
Member Author

It's the Mariner base image itself. The WASM build legs build the "cross" tools on the base image. We don't ship those components; we build them again in another leg to produce the "cross" tools built against the correct target rootfs. We only hit this problem because WASM uses mono-aot-cross to build tests on Helix machines. This was working beforehand because the image where we built wasm was the same or older base image as the image we run wasm tests on.

The solution (which I need to look into) is to build the cross tools like mono-aot-cross against the correct rootfs.

@carlossanlop
Copy link
Member

Does this change need to be backported?

@jkoritzinsky
Copy link
Member Author

We're still determining the plans for these infra changes for existing release branches.

@jkoritzinsky jkoritzinsky requested a review from vargaz as a code owner June 1, 2023 18:21
@jkoritzinsky
Copy link
Member Author

/azp run runtime, dotnet-linker-tests, runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

Failures are either known or #86533

@jkoritzinsky jkoritzinsky merged commit fa4f15e into dotnet:main Jun 9, 2023
@jkoritzinsky jkoritzinsky deleted the mariner-wasm branch June 9, 2023 22:26
@lewing
Copy link
Member

lewing commented Jun 12, 2023

@jkoritzinsky
Copy link
Member Author

I'm testing out a possible fix. Should have something by EOD today hopefully.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants