Skip to content

Change our Android build and test legs to use the new CBL-Mariner-based images. #86776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2023

Conversation

jkoritzinsky
Copy link
Member

This moves us closer to having all official platforms building on CBL-Mariner-based images.

@ghost
Copy link

ghost commented May 25, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This moves us closer to having all official platforms building on CBL-Mariner-based images.

Author: jkoritzinsky
Assignees: -
Labels:

os-android, area-Infrastructure-mono

Milestone: -

@jkoritzinsky
Copy link
Member Author

/azp run runtime-android-grpc-client-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

I may have opened this a little prematurely (before the new docker images were published)... I'll rerun the pipelines tomorrow after the new images should be available.

@steveisok steveisok requested a review from akoeplinger May 26, 2023 02:26
@jkoritzinsky

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@jkoritzinsky
Copy link
Member Author

/azp run runtime-android, runtime-android-grpc-client-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-android, runtime-android-grpc-client-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jkoritzinsky
Copy link
Member Author

All the android legs passed and the failures are unrelated.

@jkoritzinsky jkoritzinsky merged commit 559f630 into dotnet:main May 26, 2023
@jkoritzinsky jkoritzinsky deleted the mariner-android branch May 26, 2023 21:38
@MichalStrehovsky
Copy link
Member

I think this broke the linux-bionic legs in the official builds. I'm monitoring them because I also made a change to bionic yesterday but we had an official build before my change merged that already had a broken bionic leg:

Official build at the commit this PR merged:
https://dnceng.visualstudio.com/internal/_build/results?buildId=2189200&view=results

Last official build before this one:
https://dnceng.visualstudio.com/internal/_build/results?buildId=2189095&view=results

Official build with my bionic change:
https://dnceng.visualstudio.com/internal/_build/results?buildId=2189352&view=results

The failure is:

  CMake Error at System.Security.Cryptography.Native/extra_libs.cmake:20 (file):
    file COPY cannot find "/usr/include/openssl": No such file or directory.
  Call Stack (most recent call first):
    System.Security.Cryptography.Native/CMakeLists.txt:14 (append_extra_cryptography_libs)

IIRC we had to do something special for OpenSSL since it's not part of the Android NDK. CC @directhex @akoeplinger @steveisok

@MichalStrehovsky
Copy link
Member

I've submitted a revert PR here in case we want to unblock quickly: #86854

I just realized Monday is a holiday on the US so it's unlikely official build will be fixed very soon. I'm not completely blocked, because I have a long backlog of other things to do, but also there's two things that I want to see an official build for and official builds are currently broken.

MichalStrehovsky added a commit that referenced this pull request May 29, 2023
jkoritzinsky added a commit that referenced this pull request May 31, 2023
… CBL-Mariner-based images. (#86776)" (#86854)"

This reverts commit abb2312.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants