add nixos ping executable path

[pedrobsaila]

Fixes #83649

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #83649

Author:	pedrobsaila
Assignees:	-
Labels:	area-System.Net
Milestone:	-

[kasperk81]

Suggested change

	private static readonly string[] s_binFolders = { "/bin/", "/sbin/", "/usr/bin/", "/system/bin", "/run/current-system/sw/bin/" };
	private static readonly string[] s_binFolders = { "/bin", "/sbin", "/usr/bin", "/system/bin", "/run/current-system/sw/bin" };

[pedrobsaila]

Path.Combine handles perfectly the cases with / at the end and without

[kasperk81]

trailing slash isn't necessary, matching /system/bin, goes easy on eyes

[ManickaP]

We don't have NixOS in our testing matrix. Did you test it manually? Or do we have a volunteer to do that?
Otherwise LGTM and thanks!

[pedrobsaila]

We don't have NixOS in our testing matrix. Did you test it manually? Or do we have a volunteer to do that?

Yes I did test it, thanks to this awesome github project https://github.com/nix-community/NixOS-WSL and thanks to the fact that the NixOS package manager contains already .NET 8.0 SDK preview 3 https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/dotnet/versions/8.0.nix

Here is the used code

Ping pingSender = new Ping();
            PingOptions options = new PingOptions();

            // Use the default Ttl value which is 128,
            // but change the fragmentation behavior.
            options.DontFragment = true;

            // Create a buffer of 32 bytes of data to be transmitted.
            string data = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
            byte[] buffer = Encoding.ASCII.GetBytes(data);
            int timeout = 120;
            PingReply reply = pingSender.Send("www.google.com", timeout, buffer, options);
            if (reply.Status == IPStatus.Success)
            {
                Console.WriteLine("Address: {0}", reply.Address.ToString());
                Console.WriteLine("RoundTrip time: {0}", reply.RoundtripTime);
                Console.WriteLine("Time to live: {0}", reply.Options.Ttl);
                Console.WriteLine("Don't fragment: {0}", reply.Options.DontFragment);
                Console.WriteLine("Buffer size: {0}", reply.Buffer.Length);
            }

Result with code in master :

Result with code in this branch :

[ManickaP]

Awesome, thank you and thanks for pointing out the NixOS on WSL project!

[ManickaP]

Thank you!

[ManickaP]

Failures: #82894, #83551 and #85145

[wfurt]

LGTM