[release/6.0] SyntaxValueProvider: avoid performance issue with syntax list containing many items #83742
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsBackport of #83483 to release/6.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Needs package changes for JSON and Logging |
ericstj
requested review from
steveharter,
layomia and
eiriktsarpalis
as code owners
rbhanda
added
Servicing-approved
|
I'm retargeting this PR to the new Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
The new process is described here: runtime/docs/project/library-servicing.md. The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues. Let me know if you have any questions. |
carlossanlop
added
Servicing-approved
There was a problem hiding this comment.
OOB changes look good.
@tarekgh @cston not sure if you saw but the new check-service-labels CI leg was stuck because there were some weird problems with GitHub Actions yesterday. The fix is to remove and readd the Servicing-approved label, and the check will get retriggered (and should pass). I did that, and you are now allowed to merge if the CI results look good to you.
|
@ericstj any more feedback or we can merge this PR? |
|
Nope, no feedback from me - just make sure CI looks good and merge |
|
CI failures are not related and already tracked/fixed. merging this. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #83483 to release/6.0
/cc @ericstj @cston
Customer Impact
Original issue: dotnet/roslyn#66475
When a source file contains a large array, performance of compilation degraded substantially (customer case was 50x observed build perf). This bug will appear as a regression from GA since this was introduced in the servicing change #72219.
Testing
Test added to cover this scenario.
Tested repro from dotnet/roslyn#66475 (comment).
Risk
Low. This just adds an additional forward iteration.