Skip to content

[browser] improve asset loading #81886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2023
Merged

[browser] improve asset loading #81886

merged 3 commits into from
Feb 9, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 9, 2023 •
edited
Loading

  • new enableDownloadRetry configuration
  • fix for actual_downloaded_assets_count assert in use case with asset.pendingDownload and dotnet.wasm
  • make AssetEntry mutable and pass it back to downloadResource API callback

@pavelsavara
* new enableDownloadRetry configuration
160b538 
* fix for actual_downloaded_assets_count assert in use case with `asset.pendingDownload`
* make `AssetEntry` mutable and pass it back to `downloadResource` API callback
@pavelsavara pavelsavara added this to the 8.0.0 milestone Feb 9, 2023
@pavelsavara pavelsavara requested a review from maraf February 9, 2023 13:53
@pavelsavara pavelsavara requested a review from lewing as a code owner February 9, 2023 13:53
@pavelsavara pavelsavara self-assigned this Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • new enableDownloadRetry configuration
  • fix for actual_downloaded_assets_count assert in use case with asset.pendingDownload
  • make AssetEntry mutable and pass it back to downloadResource API callback
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara mentioned this pull request Feb 9, 2023
Merged
maraf
maraf reviewed Feb 9, 2023
View reviewed changes
pavelsavara and others added 2 commits February 9, 2023 15:49
@pavelsavara @maraf
Update src/mono/wasm/runtime/startup.ts
e4678c4 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/wasm/runtime/assets.ts
47e702c 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit bbbe64b into dotnet:main Feb 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
@pavelsavara pavelsavara deleted the browser_assets_promise branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf