Fix use-after-free in EventPipe #81135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the assembly name host property once and store it in a function-scoped static global. The memory of this name is expected to be managed by this function, and this value will never change in the lifetime of an application.
|
Tagging subscribers to this area: @tommcdon Issue DetailsRead the assembly name host property once and store it in a function-scoped static global. The memory of this name is expected to be managed by this function, and this value will never change in the lifetime of an application. This was found with AddressSanitizer.
|
davmason
approved these changes
Jan 24, 2023
jkotas
reviewed
Jan 25, 2023
jkotas
reviewed
Jan 25, 2023
…stead of a process-long-lived SString
AaronRobinsonMSFT
approved these changes
Jan 27, 2023
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
elinor-fung
reviewed
Jan 27, 2023
Co-authored-by: Elinor Fung <elfung@microsoft.com>
elinor-fung
reviewed
Jan 27, 2023
elinor-fung
reviewed
Jan 27, 2023
|
Failures are known, merging. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the assembly name host property once and store it in a function-scoped static global. The memory of this name is expected to be managed by this function, and this value will never change in the lifetime of an application.
This was found with AddressSanitizer.