Skip to content

[release/7.0] Fix parsing the output of ping on Samsung phones #80502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 11, 2023

Backport of #80133 to release/7.0

Fixes #78990

/cc @simonrozsival

Customer Impact

Some Android installations contain a ping utility that produces slightly different output when TTL is exceeded from what our code expects. This seems to be the case at least on Samsung phones. This PR updates the parser to account for this variation.

Testing

  • Manual testing on a Samsung phone (API 31) and on Android emulators of various API levels.
  • CI - Android emulator (API 29)

Risk

Low.

@ghost ghost added the area-System.Net label Jan 11, 2023
@ghost
Copy link

ghost commented Jan 11, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #80133 to release/7.0

/cc @simonrozsival

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@simonrozsival simonrozsival added Servicing-consider Issue for next servicing release review os-android labels Jan 11, 2023
@ghost
Copy link

ghost commented Jan 11, 2023

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #80133 to release/7.0

/cc @simonrozsival

Customer Impact

Some Android installations contain a ping utility that produces slightly different output when TTL is exceeded from what our code expects. This seems to be the case at least on Samsung phones. This PR updates the parser to account for this variation.

Testing

  • Manual testing on a Samsung phone (API 31) and on Android emulators of various API levels.
  • CI - Android emulator (API 29)

Risk

Low.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Net, os-android

Milestone: -

@teo-tsirpanis teo-tsirpanis modified the milestones: 6.0.x, 7.0.x Jan 11, 2023
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 12, 2023
@leecow leecow modified the milestones: 7.0.x, 7.0.3 Jan 12, 2023
@carlossanlop
Copy link
Contributor

Approved by Tactics (7.0.3).
Signed off by area owners.
OOB changes not needed for System.Net.Ping (does not have IsPackable=true).
CI failure is unrelated: #52976
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit cb2d02e into release/7.0 Jan 12, 2023
@carlossanlop carlossanlop deleted the backport/pr-80133-to-release/7.0 branch January 12, 2023 21:43
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants