[release/7.0] Fix SignedCms certificate collection modification with attribute certificates #80188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ificates. When adding or removing certificates from the certificateSet collection, we assumed that the collection would only contain X.509 certificates. This changes the implementation so that when looking for duplicates, we skip over choices that are not an X.509 certificate when looking for a duplicate. The tests peek in to the SignedData ASN.1 to ensure that the attribute certificates are preserved during a round trip when encoding and decoding a CMS.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsBackport of #79940 to release/7.0 /cc @vcsjones Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
@bartonjs when this is ready, please add the |
bartonjs
approved these changes
Jan 5, 2023
bartonjs
added
Servicing-consider
|
Approved by Tactics (7.0.3). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79940 and #80195 to release/7.0
/cc @vcsjones
Customer Impact
Reported by a partner for
dotnet/signat #79935. When usingSignedCmswith a CMS that contains an attribute certificate, such as an RFC3161 timestamp issued by Azure Codesigning, theAddCertificateandRemoveCertificateAPIs would raise an exception when adding or removing an X.509 certificate because they did not know how to process the attribute certificate. The impact of this is that these two APIs cannot function in the presence of an attribute certificate.Testing
This introduces tests to validate behavior of a CMS that contains attribute certificates to prevent regressions.
Risk
Low. The changes are isolated and well understood.
IMPORTANT: Is this backport for a servicing release? Yes.