Skip to content

[release/7.0] Fix dump creation on MacOS Ventura #79360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2022

Backport of #79356 to release/7.0

Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This now works on the new MacOS version (Ventura) and simplifies the module enumeration quite a bit.

Issue: #79355

Customer Impact

The new MacOS version, Ventura, broke core dump generation. This greatly affects VS4Mac Watson triage.

Testing

The VS4Mac team has verified fix on both x64/arm64 Ventura.

Risk

Low risk. Affects only MacOS createdump.

Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of
enumerating all the memory regions. This works on Ventura and simplifies
the module enumeration quite a bit.
@ghost
Copy link

ghost commented Dec 7, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79356 to release/7.0

/cc @hoyosjs @mikem8361

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@tommcdon
Copy link
Member

tommcdon commented Dec 7, 2022

Issue tracked on #79355

@mikem8361 mikem8361 self-assigned this Dec 7, 2022
@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Dec 7, 2022
@jeffschwMSFT jeffschwMSFT added this to the 7.0.x milestone Dec 7, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 8, 2022
@jeffschwMSFT jeffschwMSFT modified the milestones: 7.0.x, 7.0.3 Dec 8, 2022
@jeffschwMSFT
Copy link
Member

cc @mmitche

@mikem8361
Copy link
Contributor

I need to cherry pick my changes to this back port branch before you'all re-review.

module is part of the core dump for the dump readers. They still need
to look up the "dyld_all_image_infos" symbol.
@carlossanlop
Copy link
Contributor

@jeffschwMSFT @janvorli @hoyosjs @tommcdon can we get a fresh sign-off? There was a newer commit.

@carlossanlop
Copy link
Contributor

Approved by Tactics (7.0.3).
CI is green.
No OOB changes needed.
Waiting for new sign-off for the latest commit.

@hoyosjs
Copy link
Member

hoyosjs commented Jan 4, 2023

@carlossanlop all good, signed off again

@carlossanlop carlossanlop merged commit 0211c2e into release/7.0 Jan 5, 2023
@carlossanlop carlossanlop deleted the backport/pr-79356-to-release/7.0 branch January 5, 2023 18:44
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants