-
Notifications
You must be signed in to change notification settings - Fork 5k
[release/7.0] Fix dump creation on MacOS Ventura #79360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit.
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #79356 to release/7.0 /cc @hoyosjs @mikem8361 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Issue tracked on #79355 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 7.0.x
cc @mmitche |
I need to cherry pick my changes to this back port branch before you'all re-review. |
module is part of the core dump for the dump readers. They still need to look up the "dyld_all_image_infos" symbol.
@jeffschwMSFT @janvorli @hoyosjs @tommcdon can we get a fresh sign-off? There was a newer commit. |
Approved by Tactics (7.0.3). |
@carlossanlop all good, signed off again |
Backport of #79356 to release/7.0
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This now works on the new MacOS version (Ventura) and simplifies the module enumeration quite a bit.
Issue: #79355
Customer Impact
The new MacOS version, Ventura, broke core dump generation. This greatly affects VS4Mac Watson triage.
Testing
The VS4Mac team has verified fix on both x64/arm64 Ventura.
Risk
Low risk. Affects only MacOS createdump.