Fix issue with last_gc_before_oom flag being reset by intervening gen 1 GC. #78973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThis is a refinement suggested by Maoni for earlier PR#77478 - the last_gc_before_oom flag should also not be reset by an intervening gen 1 GC. This was noticed by Maoni due to a customer issue with spurious OOM exceptions with .NET Core 7.
|
mangod9
approved these changes
Nov 29, 2022
Member
|
This looks low risk and probably the right fix, so perhaps we should optimistically port to 7? |
Contributor
Author
|
Agree it's low risk, but I'll need to do some more testing on this before porting to 7 regardless. |
mangod9
pushed a commit
to mangod9/runtime
that referenced
this pull request
Dec 2, 2022
… 1 GC. (dotnet#78973) This is a refinement suggested by Maoni for earlier PR#77478 - the last_gc_before_oom flag should also not be reset by an intervening gen 1 GC. This was noticed by Maoni due to a customer issue with spurious OOM exceptions with .NET Core 7.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refinement suggested by Maoni for earlier PR #77478 - the last_gc_before_oom flag should also not be reset by an intervening gen 1 GC.
This was noticed by Maoni due to a customer issue with spurious OOM exceptions with .NET Core 7.