[release/7.0] Fix relative symlink support in TarFile #78470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…romDirectory.File.Roundtrip.cs Co-authored-by: David Cantú <dacantu@microsoft.com>
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #77338 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
carlossanlop
approved these changes
Nov 16, 2022
carlossanlop
added
Servicing-consider
|
Approved by Tactics via email. CI is green. Approved by area owner. No OOB package authoring changes needed. |
jeffhandley
approved these changes
Nov 18, 2022
|
Branding has been done. Milestone is 7.0.2. CI is green. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #77338 to release/7.0
/cc @jozkee @am11
Customer Impact
Path.Combine(destinationDirectory, path)resulted in a path outside of the destination directory. Said Path combination was incorrect since links targets are relative to where the link is located.With this fix, symlinks with relative targets don’t run into unexpected exceptions and their relative target is correctly preserved on extraction.
It is an important scenario as relative symlinks are perhaps the most common kind of symlink for their portability and both issues stated above would mess with that.
Testing
Added tests for relative targets pointing inside (OK) and outside (Throw) the destination directory, combined with the link being in multiple levels of the destination directory.
Risk
Low, System.Formats.Tar is a new feature in 7.0