Skip to content

[release/7.0] Fix OCSP test responder to omit fractional seconds #77437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[release/7.0] Fix OCSP test responder to omit fractional seconds #77437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...raries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,18 @@ singleExtensions [1] EXPLICIT Extensions OPTIONAL }
}
else if (status == CertStatus.Revoked)
{
// Android does not support all precisions for seconds - just omit fractional seconds for testing on Android
writer.PushSequence(s_context1);
writer.WriteGeneralizedTime(revokedTime, omitFractionalSeconds: OperatingSystem.IsAndroid());

// Fracational seconds "MUST NOT" be used here. Android and macOS 13+ enforce this and
// reject GeneralizedTime's with fractional seconds, so omit them.
// RFC 6960: 4.2.2.1:
// The format for GeneralizedTime is as specified in Section 4.1.2.5.2 of [RFC5280].
// RFC 5280 4.1.2.5.2:
// For the purposes of this profile, GeneralizedTime values MUST be
// expressed in Greenwich Mean Time (Zulu) and MUST include seconds
// (i.e., times are YYYYMMDDHHMMSSZ), even where the number of seconds
// is zero. GeneralizedTime values MUST NOT include fractional seconds.
writer.WriteGeneralizedTime(revokedTime, omitFractionalSeconds: true);
writer.PopSequence(s_context1);
}
else
Expand Down