[release/7.0] Preserve last error for patchpoint helpers #76200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
In stress modes (and eventually perhaps in normal uses) the jit may insert patchpoint helper calls in regions where last error is live. So the helpers need to preserve last error. Because some invocations of the helpers may transition to OSR methods instead of returning, we can't use the normal macros for this. Fixes #75828.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #75922 to release/7.0 /cc @AndyAyersMS Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jkotas
approved these changes
Sep 26, 2022
|
@AndyAyersMS if this is ready, please add the |
jeffschwMSFT
approved these changes
Sep 26, 2022
JulieLeeMSFT
added
Servicing-approved
|
@carlossanlop this is approved from tactics. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75922 to release/7.0
Original issue Fixes #75828.
/cc @AndyAyersMS
Customer Impact
Some applications that rely on proper last error values may fail when run on .NET 7, because of jit-inserted calls to the patchpoint helper. Proper diagnosis of this failure may be difficult for customers.
Regression
Yes, this helper is used by OSR (On Stack Replacement) which is newly enabled in .NET 7.
Testing
Normal CI testing, plus additional libraries-pgo testing (where bug was first uncoverd), plus new test added.
Risk
Low, the fix preserves last error in the patchpoint helper, similar to what is done in many other runtime entry points.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.