[release/7.0] Enable EventSource support in crossgen2 #76056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was disabled by default in #76000. I started filling out the backport template when it hit me that we want to keep it here. We'll want to backport these in tandem.
MichalStrehovsky
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Sep 23, 2022
jkotas
approved these changes
Sep 23, 2022
|
@MichalStrehovsky don't forget to send the email to Tactics requesting approval, if you haven't done so. |
|
This got approved by Tactics in the same email as #76052 |
carlossanlop
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76053 to release/7.0
/cc @MichalStrehovsky
Customer Impact
#76052 is disabling EventSource support for NativeAOT executables by default. But our perf lab testing relies on EventSource tracing to track crossgen2 perf characteristics. Not generating ETW events might have consequences for perf signoffs.
Testing
CI tests.
Risk
Next to zero - this is just restoring configuration to how it was before #76052.