-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[release/7.0] Fix WebProxy Race Condition Issue #75246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #75193 to release/7.0 /cc @liveans Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Co-authored-by: Karel Zikmund <karelz@microsoft.com>
The comment changes should be ported back to main. |
@danmoseley can we get your autograph of approval, please? |
The test failure was a timeout in System.Net.Quic.Functional tests:
|
@rzikm mentioned we see some of this on RH7 and Debian 10. investigation is pending. |
Approved - regression of functionality in 7.0, impacting customers, we'd presumably potentially service for it. |
The failure is unrelated to the change @carlossanlop -- removing NO-MERGE |
Signed off, approved and CI passed (failure unrelated). Ready to merge. |
Backport of #75193 to release/7.0
Fixes #75134 .
/cc @liveans
Customer Impact
Regression against 6.0.
Edge-case race condition in WebProxy, introduced during 7.0 (in PR #73803) - so a regression against 6.0.
Discovered by code review.
Testing
CI functional tests are passing.
Risk
N/A