Skip to content

[release/7.0] Fix WebProxy Race Condition Issue #75246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2022

Backport of #75193 to release/7.0

Fixes #75134 .

/cc @liveans

Customer Impact

Regression against 6.0.
Edge-case race condition in WebProxy, introduced during 7.0 (in PR #73803) - so a regression against 6.0.
Discovered by code review.

Testing

CI functional tests are passing.

Risk

N/A

liveans and others added 4 commits September 8, 2022 08:28
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@ghost ghost added the area-System.Net label Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75193 to release/7.0

/cc @liveans

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@liveans liveans linked an issue Sep 8, 2022 that may be closed by this pull request
@karelz karelz added this to the 7.0.0 milestone Sep 8, 2022
Co-authored-by: Karel Zikmund <karelz@microsoft.com>
@stephentoub
Copy link
Member

The comment changes should be ported back to main.

@carlossanlop
Copy link
Contributor

@danmoseley can we get your autograph of approval, please?

@carlossanlop
Copy link
Contributor

The test failure was a timeout in System.Net.Quic.Functional tests:

  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 106 of 112 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
['System.Net.Quic.Functional.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@wfurt
Copy link
Member

wfurt commented Sep 8, 2022

Console log: 'System.Net.Quic.Functional.Tests' from job 8c59ac06-efb1-4dbd-9e06-f5ccc15761b6 workitem f275f9fa-aba4-402a-a481-d1291cea82e9 (redhat.7.amd64.open.svc) executed on machine a0003EX running Linux-3.10.0-1160.76.1.el7.x86_64-x86_64-with-redhat-7.9-Maipo

@rzikm mentioned we see some of this on RH7 and Debian 10. investigation is pending.

@carlossanlop
Copy link
Contributor

@rzikm mentioned we see some of this on RH7 and Debian 10. investigation is pending.

@wfurt I'll add the "no merge" label to this PR until that failure is confirmed to be unrelated to this change.

@carlossanlop carlossanlop added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 8, 2022
@danmoseley
Copy link
Member

Approved - regression of functionality in 7.0, impacting customers, we'd presumably potentially service for it.

@karelz
Copy link
Member

karelz commented Sep 9, 2022

The failure is unrelated to the change @carlossanlop -- removing NO-MERGE

@karelz karelz removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 9, 2022
@carlossanlop
Copy link
Contributor

Signed off, approved and CI passed (failure unrelated). Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit b81eb4f into release/7.0 Sep 9, 2022
@carlossanlop carlossanlop deleted the backport/pr-75193-to-release/7.0 branch September 9, 2022 01:19
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge-case race condition in WebProxy
7 participants