JIT: Fix unrecognized unaligned field indirections on ARM32 #75078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For large field offsets we need to insert explicit null checks. This was breaking recognition of unaligned accesses that needs special treatment for floating point instructions. Fix dotnet#74260
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFor large field offsets we need to insert explicit null checks. This was Fix #74260
|
Member
|
@jakobbotsch, once completing this, please backport this to 7.0. |
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
jakobbotsch
commented
Sep 7, 2022
| internal struct FloatNonAlignedFieldWithLargeOffset | ||
| { | ||
| [FieldOffset(1021)] | ||
| [FieldOffset(0x10001)] |
Member
Author
There was a problem hiding this comment.
This is just making the field offset large enough for the problem to happen even without stress.
BruceForstall
approved these changes
Sep 7, 2022
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3013766751 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large field offsets we need to insert explicit null checks. This was
breaking recognition of unaligned accesses that needs special treatment
for floating point instructions.
Fix #74260