Skip to content

[release/7.0][wasm] Add CI job for AOT+SIMD to runtime-wasm for PRs #75064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

radical
Copy link
Member

@radical radical commented Sep 3, 2022

  • Adds a job to runtime-wasm that runs all the AOT tests with SIMD enabled
  • Also, add two System.Runtime.Intrinsics runs on helix with, and without simd
    • And run this with smoke tests too
  • And add a runtime-wasm-features pipeline yml with the AOT+SIMD job. This isn't usable right now because we can't add new pipelines.

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 3, 2022
@ghost
Copy link

ghost commented Sep 3, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@ghost ghost assigned radical Sep 3, 2022
@radical
Copy link
Member Author

radical commented Sep 3, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical changed the title [wasm] Rename WasmSIMD to WasmEnableSIMD [IGNORE][wasm] add simd testing on ci Sep 3, 2022
@radical
Copy link
Member Author

radical commented Sep 3, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 3, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 3, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 3, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 4, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 5, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 5, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 5, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 5, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 5, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 6, 2022

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Sep 7, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical marked this pull request as ready for review September 7, 2022 17:14
@radical radical requested a review from lewing as a code owner September 7, 2022 17:14
@radical
Copy link
Member Author

radical commented Sep 7, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor

Since this is an infra/test only change, it's tell mode, so I only need a sign-off from @lewing || @steveisok || @akoeplinger || @radekdoulik .

And of course, a confirmation from @radical that this is ready to merge (in case you need to push more changes and/or execute more runtime-wasm jobs).

@radical
Copy link
Member Author

radical commented Sep 8, 2022

Failures are relevant, I'll fix.

@radical radical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 8, 2022
@radical
Copy link
Member Author

radical commented Sep 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 8, 2022
@radical
Copy link
Member Author

radical commented Sep 8, 2022

The PR is ready. There are simd test failures which will be fixed by other follow up PRs.

@carlossanlop
Copy link
Contributor

Thanks @radical .
Infra/test change only.
Signed off.
CI is green.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit f8b6128 into dotnet:release/7.0 Sep 8, 2022
@radical radical deleted the fix-wbt-simd-test branch September 8, 2022 17:16
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
@radical
Copy link
Member Author

radical commented Oct 10, 2022

/backport to main

@radical radical restored the fix-wbt-simd-test branch October 10, 2022 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants