Skip to content

Update Roslyn compiler build #75058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2022
Merged

Update Roslyn compiler build #75058

merged 3 commits into from
Sep 6, 2022

Conversation

cston
Copy link
Contributor

@cston cston commented Sep 3, 2022

Update to compiler build 4.4.0-3.22431.10 with support for RefSafetyRulesAttribute.

@ghost ghost assigned cston Sep 3, 2022
@ghost
Copy link

ghost commented Sep 3, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@stephentoub
Copy link
Member

It looks like this is also bringing in dotnet/roslyn#63264 which is causing build failures due to the interop analyzer assembly being referenced multiple times.
cc: @jkoritzinsky, @ViktorHofer

@cston cston marked this pull request as ready for review September 4, 2022 01:02
@ghost
Copy link

ghost commented Sep 5, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Update to compiler build 4.4.0-3.22431.10 with support for RefSafetyRulesAttribute.

Author: cston
Assignees: cston
Labels:

area-Infrastructure
Milestone: -

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 5, 2022 •
edited
Loading

It looks like this is also bringing in dotnet/roslyn#63264 which is causing build failures due to the interop analyzer assembly being referenced multiple times.

Ack. Will submit a PR to fix the double reference shortly. EDIT: #75083

ViktorHofer added a commit that referenced this pull request Sep 5, 2022
@ViktorHofer
Remove duplicate SourceGeneration generator refs
d1302cc 
Unblocks #75058

The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
@ViktorHofer ViktorHofer mentioned this pull request Sep 5, 2022
Merged
ViktorHofer added a commit that referenced this pull request Sep 5, 2022
@ViktorHofer
Remove duplicate SourceGeneration generator refs (#75083)
60be1de 
* Remove duplicate SourceGeneration generator refs

Unblocks #75058

The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.

* Update System.Net.Http.csproj
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 5, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 5, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 5, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 5, 2022
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
@ViktorHofer
Remove duplicate SourceGeneration generator refs
c68c0ab 
Unblocks #75058

The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
ViktorHofer
ViktorHofer approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious, will the 7.0-rc1 SDK contain the require compiler bits or do we need a 7.0-rc2 SDK?

@cston cston requested a review from jaredpar September 6, 2022 17:23
@jaredpar
Copy link
Member

jaredpar commented Sep 6, 2022

LGTM. Just curious, will the 7.0-rc1 SDK contain the require compiler bits

No.

or do we need a 7.0-rc2 SDK?

The RC2 SDK will have the new bits but they package update effectively shoves the compiler bits into the RC1 SDK.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 538065b into dotnet:main Sep 6, 2022
@cston
Copy link
Contributor Author

cston commented Sep 6, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3002694152

@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Merged
carlossanlop pushed a commit that referenced this pull request Sep 6, 2022
@github-actions @ViktorHofer
[release/7.0] Remove duplicate SourceGeneration generator refs (#75128)
b69e591 
* Remove duplicate SourceGeneration generator refs

Unblocks #75058

The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.

* Update System.Net.Http.csproj

* Update System.Net.WebSockets.Client.csproj

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@cston cston deleted the update-compiler branch September 7, 2022 20:02
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@jaredpar jaredpar Awaiting requested review from jaredpar

Assignees

@cston cston

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cston @stephentoub @ViktorHofer @jaredpar @AaronRobinsonMSFT