Skip to content

Fix W^X flag for setting ITypeInfo #75045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2022
Merged

Fix W^X flag for setting ITypeInfo #75045

merged 2 commits into from
Sep 5, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

Fixes #75035

/cc @dotnet/interop-contrib @jkotas @janvorli

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Sep 3, 2022
@AaronRobinsonMSFT
Copy link
Member Author

/azp backport to release/7.0

@azure-pipelines
Copy link

Command 'backport' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@AaronRobinsonMSFT
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2982895081

jkotas
jkotas reviewed Sep 3, 2022
View reviewed changes
@github-actions github-actions bot mentioned this pull request Sep 3, 2022
Merged
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit be68496 into dotnet:main Sep 5, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_75035 branch September 5, 2022 20:23
@danmoseley
Copy link
Member

danmoseley commented Sep 5, 2022 •
edited
Loading

Is a test feasible?

@AaronRobinsonMSFT
Copy link
Member Author

Is a test feasible?

Not really. It is going to require a TLB fiddling and some esoteric build steps or esoteric Win32 API usage to get a registered TLB. Either way falls into the technical bucket of "icky".

@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-Interop-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

AV in GetITypeInfoForMT
3 participants
@AaronRobinsonMSFT @danmoseley @jkotas