Skip to content

Disallow TarWriter from writing link entries without LinkName set #74892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2022
Merged

Disallow TarWriter from writing link entries without LinkName set #74892

merged 5 commits into from
Sep 2, 2022

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Aug 31, 2022 •
edited
Loading

Fixes #74887

@carlossanlop carlossanlop self-assigned this Aug 31, 2022
jozkee
jozkee reviewed Aug 31, 2022
View reviewed changes
@carlossanlop @jozkee
Apply suggestions from code review
019b8b8 
Co-authored-by: David Cantú <dacantu@microsoft.com>
jozkee
jozkee reviewed Sep 1, 2022
View reviewed changes
@carlossanlop carlossanlop requested a review from jozkee September 1, 2022 04:05
@carlossanlop
Copy link
Contributor Author

@danmoseley permission to backport this bug fix?

@danmoseley
Copy link
Member

Ok, as part of completing the feature.

@jozkee
Copy link
Member

jozkee commented Sep 1, 2022

Note: last commit didn't trigger CI, so please avoid merging until then.

@jozkee jozkee added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 1, 2022
@carlossanlop
Copy link
Contributor Author

The CI change to update the servers has been merged to main, so we are unblocked. I am closing and reopening this PR to make sure the CI runs against the last commit.

@carlossanlop carlossanlop reopened this Sep 1, 2022
@carlossanlop carlossanlop removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 1, 2022
@carlossanlop
Copy link
Contributor Author

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2973405870

@github-actions github-actions bot mentioned this pull request Sep 1, 2022
Merged
@carlossanlop
Copy link
Contributor Author

Checked the CI results, nothing related to Tar. This is signed off, so it's ready to merge.

@carlossanlop carlossanlop merged commit 4cefab0 into dotnet:main Sep 2, 2022
@carlossanlop carlossanlop deleted the TarWriterThrowEmptyLinkName branch September 2, 2022 00:09
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@jozkee jozkee jozkee approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees

@carlossanlop carlossanlop

Labels
area-System.Formats.Tar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TarWriter allows to write invalid link entries that are unable to extract
4 participants
@carlossanlop @danmoseley @jozkee @stephentoub