[debugger][wasm] Fixes trying to evaluate a debugger helper function in a non-wasm page. #74434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsThis will only happen when debugging from VS because we receive a Runtime.executionContextCreated and try to check RuntimeReady, then we call SendDebuggerAgentCommand and this was throwing an exception. To force this behavior in the test case I created a new test case that will force a call to RuntimeReady in a non-wasm-page.
|
Member
|
@thaystg is there information we can collect to help speed up troubleshooting these types of issues? |
lewing
approved these changes
Aug 23, 2022
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2914633092 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only happen when debugging from VS because we receive a Runtime.executionContextCreated and try to check RuntimeReady, then we call SendDebuggerAgentCommand and this was throwing an exception.
To force this behavior in the test case I created a new test case that will force a call to RuntimeReady in a non-wasm-page.
Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/1557
Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/1559
Fixes #74064