-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/7.0-rc1] Improve performance of Tar library #74305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-rc1] Improve performance of Tar library #74305
Conversation
Not a perf thing, just readability.
…sync variants, and overhaul GenerateExtendedAttributesDataStream
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #74281 to release/7.0-rc1 /cc @carlossanlop @stephentoub Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
This change is relatively large and mostly optional (if current performance is considered shippable). As last time, we will have essentially no time to react to RC1 feedback before GA. Is there a subset (including the functional fixes) that would get most of the benefit with less risk of introducing a bug? I'm not necessarily opposed to taking it all, if the risk/value is there. But polishing a new feature does not meet the bar in itself. |
|
I'm going to close this per above. It is too late for this kind of change. If there are functional fixes in here that meet the bar please extract those to port them. |
Backport of #74281 to release/7.0-rc1
/cc @carlossanlop @stephentoub
Customer Impact
This is a new feature for 7.0. Customer impact should be minimal but they will get considerable performance improvements. See description in original PR.
Testing
The CI passed.
Risk
Low, new feature in 7.0.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.