Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 21, 2022

Backport of #74281 to release/7.0-rc1

/cc @carlossanlop @stephentoub

Customer Impact

This is a new feature for 7.0. Customer impact should be minimal but they will get considerable performance improvements. See description in original PR.

Testing

The CI passed.

Risk

Low, new feature in 7.0.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost ghost added the area-System.IO label Aug 21, 2022
@ghost
Copy link

ghost commented Aug 21, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74281 to release/7.0-rc1

/cc @carlossanlop @stephentoub

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.IO

Milestone: -

@carlossanlop carlossanlop self-assigned this Aug 21, 2022
@danmoseley
Copy link
Member

This change is relatively large and mostly optional (if current performance is considered shippable). As last time, we will have essentially no time to react to RC1 feedback before GA.

Is there a subset (including the functional fixes) that would get most of the benefit with less risk of introducing a bug?

I'm not necessarily opposed to taking it all, if the risk/value is there. But polishing a new feature does not meet the bar in itself.

@danmoseley
Copy link
Member

I'm going to close this per above. It is too late for this kind of change. If there are functional fixes in here that meet the bar please extract those to port them.

@danmoseley danmoseley closed this Aug 21, 2022
@danmoseley danmoseley deleted the backport/pr-74281-to-release/7.0-rc1 branch August 21, 2022 15:56
@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants