Skip to content

[release/7.0-rc1] Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test #74181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2022
Merged

[release/7.0-rc1] Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test #74181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a34cabc
Fixed #70330
sakno Aug 17, 2022
59dc497
Removed pessimistic buffer cleanup
sakno Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,11 @@ public static void Pow(ReadOnlySpan<uint> value, uint power,
Span<uint> valueCopy = (size <= StackAllocThreshold ?
stackalloc uint[StackAllocThreshold]
: valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
valueCopy.Clear();

// smallish optimization here:
// subsequent operations will copy the elements to the beginning of the buffer,
// no need to clear everything
valueCopy.Slice(value.Length).Clear();

if (value.Length > modulus.Length)
{
Expand Down Expand Up @@ -262,7 +266,11 @@ public static void Pow(ReadOnlySpan<uint> value, ReadOnlySpan<uint> power,
Span<uint> valueCopy = (size <= StackAllocThreshold ?
stackalloc uint[StackAllocThreshold]
: valueCopyFromPool = ArrayPool<uint>.Shared.Rent(size)).Slice(0, size);
valueCopy.Clear();

// smallish optimization here:
// subsequent operations will copy the elements to the beginning of the buffer,
// no need to clear everything
valueCopy.Slice(value.Length).Clear();

if (value.Length > modulus.Length)
{
Expand Down Expand Up @@ -464,7 +472,7 @@ private static Span<uint> PowCore(Span<uint> value, int valueLength,
power >>= 1;
}

return result.Slice(0, resultLength);
return result;
}

private static Span<uint> PowCore(Span<uint> value, int valueLength,
Expand Down
12 changes: 12 additions & 0 deletions src/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,18 @@ public static void ModPowAxiom()
}
}

[Fact]
public static void RegressionIssue70330()
{
byte[] tempByteArray1 = { 226, 32 };
byte[] tempByteArray2 = { 113 };
byte[] tempByteArray3 = { 15, 8, 201, 158, 96, 200, 233, 243, 184, 0, 33, 203, 210, 80, 174, 198, 244, 177, 223, 221, 168, 243, 233, 133, 103, 252, 219, 195, 187, 227, 215, 54, 66, 248, 37, 186, 232, 45, 227, 147, 100, 14, 121, 244, 56, 89, 181, 120, 205, 4, 59, 48, 65, 239, 221, 28, 30, 68, 55, 99, 237, 38, 56, 213, 40, 234, 136, 218, 42, 244, 222, 198, 205 };
VerifyIdentityString(
Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "tModPow",
Print(tempByteArray3) + Print(tempByteArray2) + Print(tempByteArray1) + "bPow" + " bRemainder"
);
}

[Fact]
public static void ModPowBoundary()
{
Expand Down