Skip to content

Disable ConnectWithRevocation_WithCallback test #74168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2022
Merged

Disable ConnectWithRevocation_WithCallback test #74168

merged 2 commits into from
Aug 22, 2022

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Aug 18, 2022

Contributes to #74034.

@ghost ghost assigned rzikm Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #74034.

Author: rzikm
Assignees: -
Labels:

area-System.Net.Security
Milestone: -

@rzikm rzikm requested a review from a team August 18, 2022 18:55
CarnaViire
CarnaViire approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

CarnaViire
CarnaViire requested changes Aug 18, 2022
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note Jeremy's comment on the issue:

I only see the failures occurring on OSX, so it should only be disabled on OSX, not all Unixes. (The Linuxes are passing stably)

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 18, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 21, 2022
@danmoseley
Copy link
Member

danmoseley commented Aug 21, 2022

I edited to OSX so validation could rerun. note that doesn't include iOS and tvOS, not sure whether those are relevant.

@danmoseley
Copy link
Member

danmoseley commented Aug 21, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 21, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Aug 22, 2022

I edited to OSX so validation could rerun. note that doesn't include iOS and tvOS, not sure whether those are relevant.

I am not aware of any failures on those, so it either works there or is disabled by some other means.

@rzikm
Copy link
Member Author

rzikm commented Aug 22, 2022

/azp run runtime

@rzikm
Copy link
Member Author

rzikm commented Aug 22, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Aug 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm rzikm requested a review from CarnaViire August 22, 2022 10:03
@rzikm
Copy link
Member Author

rzikm commented Aug 22, 2022

CI failures are weird, but build succeeded and the test itself is actually not outerloop so any failures are not result of this change.

@rzikm rzikm merged commit bd7e60a into dotnet:main Aug 22, 2022
@karelz karelz added this to the 8.0.0 milestone Aug 23, 2022
@karelz karelz mentioned this pull request Aug 24, 2022
Closed
@rzikm
Copy link
Member Author

rzikm commented Aug 24, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2917382995

@github-actions github-actions bot mentioned this pull request Aug 24, 2022
Merged
@karelz karelz mentioned this pull request Aug 25, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danmoseley danmoseley danmoseley left review comments

@CarnaViire CarnaViire CarnaViire approved these changes

Assignees

@rzikm rzikm

Labels

area-System.Net.Security

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rzikm @danmoseley @CarnaViire @karelz