Skip to content

[workloads] Shorten the workload name even more #74150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[workloads] Shorten the workload name even more #74150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/workloads/workloads.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@
<!-- Shorten package names to avoid long path issues in Visual Studio -->
<ItemGroup>
<!-- These need to be in order - matching rules will try in order. -->
<ShortNames Include="Microsoft.NET.Workload.Mono.ToolChain.Manifest">
<Replacement>MonoToolChainManifest</Replacement>
<ShortNames Include="Microsoft.NET.Workload.Mono.ToolChain.">
Copy link
Member

@filipnavara filipnavara Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much shortening on this line? :-)

Copy link
Member Author

@lewing lewing Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it matches from the start ;)

Copy link
Member

@joeloff joeloff Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we'll end up with mono.manifest or something like that?

Copy link
Member

@joeloff joeloff Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I noticed there's already a VSIX package in VS with an ID called "Mono", so as long as we have another qualifier we should be okay.

Copy link
Member Author

@lewing lewing Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should end up as MonoManifest-7.0.100

<Replacement>Mono</Replacement>
</ShortNames>
<ShortNames Include="microsoft.netcore.app.runtime;Microsoft.NETCore.App.Runtime;microsoft.net.runtime;Microsoft.NET.Runtime">
<Replacement>Microsoft</Replacement>
Expand Down