Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Aug 18, 2022

No description provided.

@ghost ghost added the area-Build-mono label Aug 18, 2022
@ghost ghost assigned lewing Aug 18, 2022
@lewing lewing requested a review from hoyosjs August 18, 2022 14:23
<!-- These need to be in order - matching rules will try in order. -->
<ShortNames Include="Microsoft.NET.Workload.Mono.ToolChain.Manifest">
<Replacement>MonoToolChainManifest</Replacement>
<ShortNames Include="Microsoft.NET.Workload.Mono.ToolChain.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much shortening on this line? :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it matches from the start ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we'll end up with mono.manifest or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I noticed there's already a VSIX package in VS with an ID called "Mono", so as long as we have another qualifier we should be okay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should end up as MonoManifest-7.0.100

hoyosjs
hoyosjs previously approved these changes Aug 18, 2022
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh... This limit is painful

@hoyosjs hoyosjs dismissed their stale review August 18, 2022 14:56

Wait. Looks like it no longer has the Replacement metadata?

@lewing lewing requested a review from joeloff August 18, 2022 16:52
@lewing
Copy link
Member Author

lewing commented Aug 18, 2022

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2885146213

@lewing lewing merged commit 0b2e6d6 into main Aug 18, 2022
@lewing lewing deleted the workload-shortname branch August 18, 2022 20:55
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants