Skip to content

[release/7.0-rc1] [NativeAOT] Add method parameter names to stack trace if available #74145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2022

Backport of #73578 to release/7.0-rc1

/cc @MichalStrehovsky @jasper-d

Customer Impact

Method parameter names didn't show up in stack traces. This is not compatible with how IL Linker does this - there the method parameters show up if the method was a visible target of reflection. We had the necessary data but didn't print it. I believe this fits the unapproved compatibility break bucket.

Testing

Manual testing, automated tests that were previously failing.

Risk

Low, this is only used in exception stack stringification.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 18, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. Please get a code review and once we have a green ci we can merge.

@carlossanlop
Copy link
Contributor

approved. Please get a code review and once we have a green ci we can merge.

@jeffschwMSFT This was approved by @MichalStrehovsky in main (submitted by external contributor). So I think we're good?

@carlossanlop
Copy link
Contributor

Failures are unrelated:

Ready to merge.

@carlossanlop carlossanlop merged commit 0ec29b6 into release/7.0-rc1 Aug 18, 2022
@carlossanlop carlossanlop deleted the backport/pr-73578-to-release/7.0-rc1 branch August 18, 2022 17:32
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants