Skip to content

Disable failing runtime extra platforms tests #74143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 19, 2022
Merged

Disable failing runtime extra platforms tests #74143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
049af5c
Disable tests failing on Android
simonrozsival Aug 17, 2022
9c0bda3
Disable test failing on iOS and MacCatalyst
simonrozsival Aug 18, 2022
a562c1f
Merge branch 'main' of github.com:dotnet/runtime into disable-failing…
simonrozsival Aug 18, 2022
bfc2958
Disable failing System.Formats.Tar tests on Android
simonrozsival Aug 18, 2022
90f708c
Fix JIT.Directed aliasing_retbuf test exclusion on Android
simonrozsival Aug 18, 2022
724b84c
Disable failing TraceSource tests on tvOS
simonrozsival Aug 18, 2022
d2bb5b0
Remove unnecessary formatting changes
simonrozsival Aug 18, 2022
e30e572
Fix skipping failing tests on Android
simonrozsival Aug 18, 2022
59b49d6
Skip tests failing on tvOS
simonrozsival Aug 18, 2022
5e217c8
Revert "Disable failing System.Formats.Tar tests on Android"
simonrozsival Aug 19, 2022
ae1f142
Link to specific issues
simonrozsival Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ce/tests/System.Diagnostics.TraceSource.Config.Tests/TraceSourceWithConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ private static void CreateAndLoadConfigFile(string filename)

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void RuntimeFilterChange()
{
CreateAndLoadConfigFile("testhost_ConfigWithRuntime.config");
Expand Down Expand Up @@ -95,6 +96,7 @@ public void RuntimeFilterChange()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Refresh_RemoveSwitch()
{
// Use a SourceSwitch that logs Error.
Expand Down Expand Up @@ -135,6 +137,7 @@ void Log()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Refresh_ChangeSwitch()
{
// Use a SourceSwitch that logs Error.
Expand All @@ -160,6 +163,7 @@ public void Refresh_ChangeSwitch()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Refresh_RemoveSource()
{
// Use a SourceSwitch that logs Error.
Expand Down Expand Up @@ -193,6 +197,7 @@ public void Refresh_RemoveSource()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void ConfigWithEvents_RuntimeListener()
{
CreateAndLoadConfigFile("testhost_ConfigWithRuntime.config");
Expand Down Expand Up @@ -259,6 +264,7 @@ private void SubscribeToSwitch_Initializing(object? sender, InitializingSwitchEv

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void AllTypes()
{
CreateAndLoadConfigFile("testhost_AllTypes.config");
Expand Down Expand Up @@ -303,6 +309,7 @@ public void AllTypes()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Switch_MissingValue_Throws()
{
Exception e = Assert.Throws<ConfigurationErrorsException>(() =>
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3752,6 +3752,7 @@ public abstract class SocketsHttpHandler_SecurityTest : HttpClientHandlerTestBas
public SocketsHttpHandler_SecurityTest(ITestOutputHelper output) : base(output) { }

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindows7))]
[SkipOnPlatform(TestPlatforms.Android, "Self-signed certificates are rejected by Android before the .NET validation is reached")]
public async Task SslOptions_CustomTrust_Ok()
{
X509Certificate2Collection caCerts = new X509Certificate2Collection();
Expand Down Expand Up @@ -3788,6 +3789,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[SkipOnPlatform(TestPlatforms.Android, "Self-signed certificates are rejected by Android before the .NET validation is reached")]
public async Task SslOptions_InvalidName_Throws()
{
X509Certificate2Collection caCerts = new X509Certificate2Collection();
Expand Down Expand Up @@ -3818,6 +3820,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[SkipOnPlatform(TestPlatforms.Android, "Self-signed certificates are rejected by Android before the .NET validation is reached")]
public async Task SslOptions_CustomPolicy_IgnoresNameMismatch()
{
X509Certificate2Collection caCerts = new X509Certificate2Collection();
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ public static void Xml_ListRoot()
// horizon that it's not worth the trouble.
#if !XMLSERIALIZERGENERATORTESTS
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74247", TestPlatforms.tvOS)]
public static void Xml_ReadOnlyCollection()
{
ReadOnlyCollection<string> roc = new ReadOnlyCollection<string>(new string[] { "one", "two" });
Expand All @@ -224,6 +225,7 @@ public static void Xml_ReadOnlyCollection()

[Theory]
[MemberData(nameof(Xml_ImmutableCollections_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74247", TestPlatforms.tvOS)]
public static void Xml_ImmutableCollections(Type type, object collection, Type createException, Type addException, string expectedXml, string exMsg = null)
{
XmlSerializer serializer;
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Quic/tests/FunctionalTests/System.Net.Quic.Functional.Tests.csproj" />
<!-- https://github.com/dotnet/runtime/issues/51414 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.OpenSsl/tests/System.Security.Cryptography.OpenSsl.Tests.csproj" />

<!-- https://github.com/dotnet/runtime/issues/74245 -->
<ProjectExclusions Include="$(RepoRoot)/src/tests/FunctionalTests/iOS/Simulator/XmlSerializer_Deserialize/iOS.Simulator.XmlSerializer_Deserialize.Test.csproj" />
<!-- App Crash https://github.com/dotnet/runtime/issues/53624 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Requests/tests/System.Net.Requests.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3694,7 +3694,7 @@
<ExcludeList Include = "$(XunitTestBinBase)/JIT/CheckProjects/CheckProjects/**">
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include="$(XUnitTestBinBase)/JIT/Directed/aliasing_retbuf/*">
<ExcludeList Include="$(XUnitTestBinBase)/JIT/Directed/aliasing_retbuf/**/*">
<Issue>https://github.com/dotnet/runtime/issues/73539</Issue>
</ExcludeList>
<ExcludeList Include="$(XUnitTestBinBase)/JIT/Directed/callconv/ThisCall/ThisCallTest/*">
Expand Down