Improve ControlledExecution tests #74136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
approved these changes
Aug 18, 2022
Member
Author
|
Thank you for the quick code review! |
Member
Author
|
/backport to release/7.0-rc1 |
Contributor
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2885634467 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests assumed that 200 milliseconds was enough time for a test action to start executing and get to the expected location in the code. Apparently, in some CI jobs a test action did not start in that amount of time. Make the tests more robust by ensuring that we abort every test action at the expected location. I also added several more tests and improved test names and comments.
Fixes #73647, fixes #73739.