Avoid url string allocation in WebProxy.IsMatchInBypassList #73807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsUse new the Regex.IsMatch(span) overload to avoid allocating a new string on each call. On its own this won't move the needle much, but once #73803 is in, IsMatchInBypassList will be allocation-free for all reasonable input Uris (and we could change it to use ArrayPool in the future if we found hosts that were frequently longer than this). cc: @dotnet/ncl, @joperezr
|
stephentoub
force-pushed
the
matchbypassliststring
branch
from
858fe2d to
af7b878
Compare
MihaZupan
approved these changes
Aug 11, 2022
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new the Regex.IsMatch(span) overload to avoid allocating a new string on each call. On its own this won't move the needle much, but once #73803 is in, IsMatchInBypassList will be allocation-free for all reasonable input Uris (and we could change it to use ArrayPool in the future if we found hosts that were frequently longer than this).
cc: @dotnet/ncl, @joperezr, @onehourlate