[HTTP3] Correctly handle server closing a control stream #73680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis PR makes sure we behave according to the spec when server closes/aborts either its or clients control stream (i.e. close the connection with
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ManickaP
approved these changes
Aug 10, 2022
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
Outdated
Show resolved
Hide resolved
…andler/Http3Connection.cs Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
CarnaViire
approved these changes
Aug 10, 2022
ManickaP
reviewed
Aug 10, 2022
| @@ -7,6 +7,7 @@ | |||
| using System.Runtime.Versioning; | |||
| using System.Net.Quic; | |||
| using System.IO; | |||
| using System.Linq; | |||
There was a problem hiding this comment.
Suggested change
| using System.Linq; |
There was a problem hiding this comment.
oops, I missed this one and merged it, I will remove it when I next touch HTTP3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure we behave according to the spec when server closes/aborts either its or clients control stream (i.e. close the connection with
H3_CLOSED_CRITICAL_STREAMerror)