[NativeAOT] Add method parameter names to stack trace if available #73578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-NativeAOT-coreclr
community-contribution
jasper-d
commented
Aug 8, 2022
...aot/System.Private.StackTraceMetadata/src/Internal/StackTraceMetadata/MethodNameFormatter.cs
Outdated
Show resolved
Hide resolved
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks great otherwise, thanks!
src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs
Outdated
Show resolved
Hide resolved
...aot/System.Private.StackTraceMetadata/src/Internal/StackTraceMetadata/MethodNameFormatter.cs
Outdated
Show resolved
Hide resolved
...aot/System.Private.StackTraceMetadata/src/Internal/StackTraceMetadata/MethodNameFormatter.cs
Outdated
Show resolved
Hide resolved
MichalStrehovsky
approved these changes
Aug 18, 2022
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks great, thank you!
I'll try to get this ported into .NET 7 (we snapped from the main branch on Tuesday.)
src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs
Outdated
Show resolved
Hide resolved
Member
|
/backport to release/7.0-rc1 |
Contributor
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2881987012 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After taking a look at SchemaDef, I assume that parameter names are available iff we have a (Qualified)MethodHandle.
EmitMethodParametersthat takes aMethodHandleand prints the parameters with type and name. Restructured the calling code to make use of it.Fixes #73051