Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Removed duplicated testcases as a follow-up for #70560 #71827

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 8, 2022

Theories added in #70560 contained duplicated testcases with the existing ones. The previous PR aimed at correcting the logic + adding new tests. This one cleans up the duplicates and renames some entities to make the tests clearer.

Removals and reasons:

  • EvaluateAsyncMethods is removed because inside there was a mess - inside we had a staticClass that was in fact, an instance class and the method did not test anything async. It was replaced in the previous PR with:
    EvaluateNonStaticClassWithStaticFields with 4 different methods out of which we check the OnEval reply: InstanceMethod (Run), InstanceAsyncMethod (RunAsync), StaticMethod (RunStatic), StaticAsyncMethod (RunStaticAsync)
    and
    EvaluateStaticFieldsInStaticClass with similar set of methods: StaticMethod (Run) and StaticAsyncMethod (RunAsync).
  • Because of above, all code connected to EvaluateAsyncMethods got removed, it means:
    test: EvaluateStaticClassFromStaticMethod (got replaced with EvaluateStaticFields)
    test data: yield return new object[].... (got replaced with InlineData for EvaluateStaticFields).

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Jul 8, 2022
@ilonatommy ilonatommy self-assigned this Jul 8, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Theories added in #70560 contained duplicated testcases with the existing ones. The previous PR aimed at correcting the logic + adding new tests. This one cleans up the duplicates and renames some entities to make the tests clearer.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the feedback, the changes look good.

@ilonatommy ilonatommy merged commit cd75ae1 into dotnet:main Jul 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants