[wasm][aot] Run the high resource AOT tests on build machine itself #67017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsExperiment!
|
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
radical
force-pushed
the
source-gen-build
branch
from
88b2916
to
09d617d
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…rentiate between linux, and windows
.. be selectable via `$(RunHighResourceAOTTestsOnly)`.
Some library tests fail to AOT on helix by getting oomkill'ed. Since the build machine have more resources than helix, we can AOT these specific library tests there, and send the built output to helix to run.
radical
force-pushed
the
source-gen-build
branch
from
cbb2049
to
c5549cb
Compare
radical
changed the title
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
An alternative might be to avoid AOTing Microsoft.CodeAnalysis.dll as well. It worked here: |
radekdoulik
approved these changes
Mar 25, 2022
steveisok
approved these changes
Mar 25, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Mar 25, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…otnet#67017) Some library tests fail to AOT on helix by getting oomkill'ed. Since the build machine have more resources than helix, we can AOT these specific library tests there, and send the built output to helix to run. Specifically: - `System.Text.Json.SourceGeneration.Roslyn3.11.Tests` - `System.Text.Json.SourceGeneration.Roslyn4.0.Tests` - `System.Text.Json.Tests` - `Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests` This adds two new jobs to `runtime-wasm`, and for rolling builds - `LibraryTests_HighResource_AOT` for linux, and windows. Fixes dotnet#65356 Fixes dotnet#65411 Fixes dotnet#61524 Fixes dotnet#66647
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some library tests fail to AOT on helix by getting oomkill'ed. Since the
build machine have more resources than helix, we can AOT these specific
library tests there, and send the built output to helix to run.
Specifically:
System.Text.Json.SourceGeneration.Roslyn3.11.TestsSystem.Text.Json.SourceGeneration.Roslyn4.0.TestsSystem.Text.Json.TestsMicrosoft.Extensions.Logging.Generators.Roslyn3.11.TestsThis adds two new jobs to
runtime-wasm, and for rolling builds -LibraryTests_HighResource_AOTfor linux, and windows.Fixes #65356
Fixes #65411
Fixes #61524
Fixes #66647