Skip to content

Revert "Avoid Attribute.GetCustomAttributes() returning null for open generic type" #66508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 11, 2022

Reverts #65237

Related to #66496

@ghost ghost assigned jkotas Mar 11, 2022
@ghost
Copy link

ghost commented Mar 11, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #65237

Author: jkotas
Assignees: jkotas
Labels:

area-System.Reflection

Milestone: -

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM, thanks!

@stephentoub stephentoub merged commit f99ba2e into main Mar 11, 2022
@stephentoub stephentoub deleted the revert-65237-issue-64335 branch March 11, 2022 21:12
madelson added a commit to madelson/runtime that referenced this pull request Mar 13, 2022
buyaa-n pushed a commit that referenced this pull request Mar 14, 2022
… type

* Revert "Revert "Avoid Attribute.GetCustomAttributes() returning null for open generic type (#65237)" (#66508)"

This reverts commit f99ba2e.

* Make DynamicMethod.GetCustomAttributes() return well-typed arrays.

This change makes DynamicMethod.GetCustomAttributes() compatible with
Attribute.GetCustomAttributes().
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
… type

* Revert "Revert "Avoid Attribute.GetCustomAttributes() returning null for open generic type (dotnet#65237)" (dotnet#66508)"

This reverts commit f99ba2e.

* Make DynamicMethod.GetCustomAttributes() return well-typed arrays.

This change makes DynamicMethod.GetCustomAttributes() compatible with
Attribute.GetCustomAttributes().
@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants