-
Notifications
You must be signed in to change notification settings - Fork 5k
attempt to fix up EnterpriseTests #65981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
@wfurt looking at your build, if you just set a higher timeout it'd probably pass. Why it's so slow I'd guess is the many, many, instances of this retry:
... which I'd venture could be addressed by some judicious pruning of the nuget.config file. |
Do you know how to set the overall timeout @MattGal? I did one attempt and it broke the build e.g. the pipeline would not even start. |
Oh! I thought we were talking about the nuget issue. I would convert this yaml to use stages and jobs then follow the instructions as seen here: The way you're doing it isn't super well supported any more and it's possible just putting
|
Test failures seem unrelated. Mix of infrastructure and product issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Was this the cause of the docker pull failures, e.g. in https://dev.azure.com/dnceng/public/_build/results?buildId=1643557&view=logs&j=8679535e-9046-505f-8bbe-da251e73ecbd&t=ab7958ed-5297-5b46-f99a-06ce433e067d |
no, I don't think so. This change touched only code used in the enterprise-linux path. |
Unless you accidentally pasted the wrong link, this isn't a docker pull failure. (Regardless those are mostly Mcr.microsoft.com having a bad minute or two) While it is a docker work item, this failure is :
reference query:
There's lots of retries for this talking to Azdo stage, but sometimes it just doesn't work well. It's also important to note that the "talking to azdo" stage occurs on the host, not inside the container, so we can't blame Docker for this one. |
I think there were two failures in there: the Mono llvmfull job failed with:
|
getting more clean runs on that pipeline https://dev.azure.com/dnceng/public/_build?definitionId=690&_a=summary |
* attemp to fix up EnterpriseTests * fix text * increase timoeout on build step * fix temeout * add jobs * update job * fix formating * fix name * update server check * restore original resolver before tests * fix path * experiment (cherry picked from commit 9174037)
contributes to https://github.com/dotnet/core-eng/issues/15594. It seems like te container cannot resolve outside addresses,
There may be cleaner ways how to fix this But as stop-gap, tis seems to work e.g. there is already test script so if the lookup fails it would add public server.