Skip to content

Mark SslProtocols.Tls and SslProtocols.Tls11 as obsolete #65773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 3, 2022
Merged

Mark SslProtocols.Tls and SslProtocols.Tls11 as obsolete #65773

merged 6 commits into from
Mar 3, 2022

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Feb 23, 2022 •
edited
Loading

Fixes #65546

I considered disabling the new SYSLIB0039 warning once per file where needed, but for 0618 (SSL2/3 obsoletion) we already do it per-use, so I staid consistent. Opinions welcome

@rzikm rzikm requested a review from jeffhandley as a code owner February 23, 2022 13:44
@ghost
Copy link

ghost commented Feb 23, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned rzikm Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65546

I considered disabling the new SYSLIB0039 warning once per file where needed, but for 0618 (SSL2/3 obsoletion) we already do it per-use, so I staid consistent.

Author: rzikm
Assignees: -
Labels:

area-System.Net.Security, new-api-needs-documentation
Milestone: -

@rzikm rzikm added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Feb 23, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022 •
edited by rzikm
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

wfurt
wfurt reviewed Feb 23, 2022
View reviewed changes
@runfoapp runfoapp bot mentioned this pull request Feb 23, 2022
Closed
@rzikm rzikm requested a review from wfurt February 25, 2022 09:27
@rzikm
Copy link
Member Author

rzikm commented Feb 25, 2022

Test failure is

wfurt
wfurt reviewed Mar 3, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm rzikm merged commit b8f1a06 into dotnet:main Mar 3, 2022
@rzikm rzikm mentioned this pull request Mar 3, 2022
Closed
2 tasks
@rzikm rzikm removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Mar 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs left review comments

@wfurt wfurt wfurt approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@rzikm rzikm

Labels
area-System.Net.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

mark SslProtocols.Tls and SslProtocols.Tls11 as obsolete
5 participants
@rzikm @jeffhandley @bartonjs @wfurt @karelz