Skip to content

Clean-up slngen related logic #65507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Clean-up slngen related logic #65507

merged 6 commits into from
Feb 18, 2022

Conversation

ViktorHofer
Copy link
Member

There was some dead code in the project file with the recent removal of the nuget.config update target. Also invoke slngen with the repo local SDK instead of depending on a global one being installed.

@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

There was some dead code in the project file with the recent removal of the nuget.config update target. Also invoke slngen with the repo local SDK instead of depending on a global one being installed.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

ViktorHofer and others added 2 commits February 17, 2022 19:56
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 18, 2022

@akoeplinger if possible, please approve :)

@ViktorHofer ViktorHofer merged commit ac4ec9e into main Feb 18, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch February 18, 2022 21:03
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants