Remove OpenSSL error queue checking in SslInitializer

[rzikm]

Fixes #64492

as noted by @bartonjs in #64492 (comment), nothing in the CryptoNative_EnsureLibSslInitialized puts any errors in the error queue, so it is not necessary to check it after finishing.

In 6.0, there is a possibility that if a previous crypto operation left an error in the OpenSSL error queue then SslInitializer would be prevented from completing correctly (See discussion of the original issue for more details.), this has probably been greatly reduced or even fixed by #65148 for 7.0, but backporting change made in this PR to 6.0 should be less risky and just as effective.

[ghost]

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes Issue #64492

There is a possibility that a previous crypto operation left an error in the OpenSSL error queue, which would prevent SslInitializer from completing correctly. See discussion of the original issue for more details.

Author:	rzikm
Assignees:	rzikm
Labels:	area-System.Net.Security
Milestone:	-

[wfurt]

test failure unrelated. probably outcome of #64747. Root cause may be similar to #43686.

System.Net.Security.Tests.SslStreamNetworkStreamTest.SslStream_NegotiateClientCertificateAsync_PendingDecryptedData_Throws [SKIP]
      Condition(s) not met: "SupportsRenegotiation"
Process terminated due to "Expected 7 <= 0
   at System.Diagnostics.DebugProvider.Fail(String message, String detailMessage) in /_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/DebugProvider.cs:line 22
   at System.Diagnostics.Debug.Fail(String message, String detailMessage) in /_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Debug.cs:line 131
   at System.Diagnostics.Debug.Assert(Boolean condition, String message, String detailMessage) in /_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Debug.cs:line 95
   at System.Diagnostics.Debug.Assert(Boolean condition, String message) in /_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Debug.cs:line 84
   at System.Diagnostics.Debug.Assert(Boolean condition, AssertInterpolatedStringHandler& message) in /_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Debug.cs:line 88
   at System.Net.ArrayBuffer.Discard(Int32 byteCount) in /_/src/libraries/Common/src/System/Net/ArrayBuffer.cs:line 67
   at System.Net.Security.SslStream.SslBuffer.DiscardEncrypted(Int32 byteCount) in /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs:line 152
   at System.Net.Security.SslStream.ProcessBlob(Int32 frameSize) in /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs:line 498

[wfurt]

Should we clean up the queue and put the error to trace log for troubleshooting?

[bartonjs]

Since none of the initialization code can produce errors, it's just a sign that the initializer ran on a thread where some OpenSSL-related activity had already happened (and happened to leave an error behind). I don't think it's interesting to log. (For the same reason I suggested just deleting this code)

[rzikm]

/backport to release/6.0

[github-actions]

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1858570523