Remove JsonConverter.RuntimeType #65224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackports infrastructural changes introduced in the polymorphic serialization prototype branch.
|
krwq
reviewed
Feb 15, 2022
...m.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IDictionaryConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
...m.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IEnumerableConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
...ext.Json/src/System/Text/Json/Serialization/Converters/Collection/IEnumerableOfTConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoInternalOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
...ialization/Converters/Object/ObjectWithParameterizedConstructorConverter.Large.Reflection.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
.../System/Text/Json/Serialization/Converters/Collection/StackOrQueueConverterWithReflection.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
...ext.Json/src/System/Text/Json/Serialization/Converters/Collection/JsonDictionaryConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 15, 2022
...xt/Json/Serialization/Converters/Collection/ImmutableEnumerableOfTConverterWithReflection.cs
Show resolved
Hide resolved
|
overall looks good, I think you should remove unnecessary RequiresUnreferencedCode (RUC) from the code, treat rest of the comments as enahncements and no need to block on them |
Backports changes introduced in the polymorphic deserialization prototype. JsonConverter.RuntimeType is an implementation detail stemming from interface support in collection converters, that has leaked into the JsonTypeInfo model. Removing it makes the contract model cleaner and makes the infrastructure compatible with polymorphic deserialization.
eiriktsarpalis
force-pushed
the
jsonconverter-runtimetype
branch
from
f165444 to
88cec71
Compare
krwq
approved these changes
Feb 15, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports infrastructural changes introduced in the polymorphic serialization prototype branch.
JsonConverter.RuntimeTypeis an implementation detail stemming from interface support in collection converters, that has leaked into theJsonTypeInfomodel. Removing it makes the contract model cleaner and makes the metadata infrastructure compatible with polymorphic deserialization.Related to #54420, #63747.